Handle response error when body contains no valid json #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caviarion
force-pushed
the
handle-non-json-error
branch
from
3670c10
to
24bc5c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
==========================================
+ Coverage 97.07% 97.10% +0.02%
==========================================
Files 17 17
Lines 719 726 +7
==========================================
+ Hits 698 705 +7
Misses 15 15
Partials 6 6
|
Caviarion
force-pushed
the
handle-non-json-error
branch
from
24bc5c4
to
c87f5ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Handle non json response correctly by returning original response content instead of returning meaningless json unmarshal error